Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DCMAW-9786] Add dev platform assets to enable testing in codebuild #68

Merged
merged 7 commits into from
Aug 15, 2024
Merged

[DCMAW-9786] Add dev platform assets to enable testing in codebuild #68

merged 7 commits into from
Aug 15, 2024

Conversation

dothomson
Copy link
Contributor

@dothomson dothomson commented Aug 7, 2024 •
edited by sandy-may
Loading

DCMAW-9786

This change includes building out the test container to be used in the dev, build and staging deployments. This is a pre-requisite for creating a post-merge Github action, which will be included in a subsequent PR.

sandy-may
sandy-may reviewed Aug 7, 2024
View reviewed changes
Copy link
Contributor

@sandy-may sandy-may left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Please may we make sure this is covered by Sonar? The sonar properties file at the root of the repo has a sonar.sources property that wouldn't capture this directory.

I think it should to make sure we've caught any docker/.sh codesmells

@sandy-may sandy-may force-pushed the DCMAW-9786-deploy-to-async-accounts branch from 5c324b3 to d80cae1 Compare August 15, 2024 11:02
@sandy-may sandy-may marked this pull request as ready for review August 15, 2024 11:14
@sandy-may sandy-may requested review from a team as code owners August 15, 2024 11:14
@sandy-may sandy-may self-requested a review August 15, 2024 11:31
@sandy-may sandy-may changed the title [DCMAW-9786] Deploy backend-api to async accounts [DCMAW-9786] Add dev platform assets to enable testing in codebuild Aug 15, 2024
@sandy-may sandy-may merged commit 416b5ae into main Aug 15, 2024
1 check passed
@sandy-may sandy-may deleted the DCMAW-9786-deploy-to-async-accounts branch August 15, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandy-may sandy-may sandy-may approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dothomson @sandy-may